Add -2.0 templates deprecation warning. #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chrisvfritz please take a look. |
chrisvfritz
suggested changes
Sep 21, 2016
| deprecation: function (template, name) { | ||
| var initCommand = 'vue init ' + template.replace('-2.0', '') + ' ' + name | ||
|
|
||
| console.log(chalk.red(' This template is deprecated.')) |
There was a problem hiding this comment.
Perhaps it would be good to add a bit more information here. For example:
This template is deprecated, as the original template now uses Vue 2.0 by default.
Just so that they know the new command will still use 2.0.
| var chalk = require('chalk') | ||
|
|
||
| module.exports = { | ||
| deprecation: function (template, name) { |
There was a problem hiding this comment.
Since we might want to have other kinds of deprecations in the future, maybe we can rename this warning to v2SuffixTemplatesDeprecated. I know it's a bit long, but I think that's fine since we're not using it constantly. It's also much clearer what's being deprecated.
| console.log(chalk.yellow(' Please use this command instead: ') + chalk.green(initCommand)) | ||
| console.log() | ||
| }, | ||
| vue2Version: function (template, name) { |
There was a problem hiding this comment.
While we're here, maybe rename this to a more descriptive v2BranchIsNowDefault? What do you think?
chrisvfritz
approved these changes
Sep 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171