Skip to content

fix(preset): plugin invoke order don't sort by unicode order #2656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2018
Merged

fix(preset): plugin invoke order don't sort by unicode order #2656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@vue/cli/lib/Creator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ module.exports = class Creator extends EventEmitter {
// { id: options } => [{ id, apply, options }]
async resolvePlugins (rawPlugins) {
// ensure cli-service is invoked first
rawPlugins = sortObject(rawPlugins, ['@vue/cli-service'])
rawPlugins = sortObject(rawPlugins, ['@vue/cli-service'], true)
const plugins = []
for (const id of Object.keys(rawPlugins)) {
const apply = loadModule(`${id}/generator`, this.context) || (() => {})
Expand Down
4 changes: 2 additions & 2 deletions packages/@vue/cli/lib/util/sortObject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module.exports = function sortObject (obj, keyOrder) {
module.exports = function sortObject (obj, keyOrder, dontSortByUnicode) {
if (!obj) return
const res = {}

Expand All @@ -11,7 +11,7 @@ module.exports = function sortObject (obj, keyOrder) {

const keys = Object.keys(obj)

keys.sort()
!dontSortByUnicode && keys.sort()
keys.forEach(key => {
res[key] = obj[key]
})
Expand Down