Skip to content

feat!: use ESLint v5 by default everywhere #3775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2019
Merged

feat!: use ESLint v5 by default everywhere #3775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions packages/@vue/cli-plugin-eslint/generator/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,7 @@ module.exports = (api, { config, lintOn = [] }, _, invoking) => {
lint: 'vue-cli-service lint'
},
eslintConfig,
// TODO:
// Move these dependencies to package.json in v4.
// Now in v3 we have to add redundant eslint related dependencies
// in order to keep compatibility with v3.0.x users who defaults to ESlint v4.
devDependencies: {
'babel-eslint': '^10.0.1',
'eslint': '^5.8.0',
'eslint-plugin-vue': '^5.0.0'
}
devDependencies: {}
}

const injectEditorConfig = (config) => {
Expand Down
6 changes: 2 additions & 4 deletions packages/@vue/cli-plugin-eslint/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,10 @@
"dependencies": {
"@vue/cli-shared-utils": "^3.5.1",
"babel-eslint": "^10.0.1",
"eslint": "^5.8.0",
"eslint-loader": "^2.1.2",
"eslint-plugin-vue": "^5.0.0",
"globby": "^9.0.0",
"webpack": ">=4 < 4.29"
},
"optionalDependencies": {
"eslint": "^4.19.1",
"eslint-plugin-vue": "^4.7.1"
}
}
4 changes: 2 additions & 2 deletions packages/@vue/cli-service-global/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
"@vue/cli-service": "^3.5.3",
"babel-eslint": "^10.0.1",
"chalk": "^2.4.2",
"eslint": "^4.19.1",
"eslint-plugin-vue": "^4.7.1",
"eslint": "^5.8.0",
"eslint-plugin-vue": "^5.0.0",
"resolve": "^1.10.0",
"vue": "^2.6.6",
"vue-template-compiler": "^2.6.6"
Expand Down