Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): suggest matching commands if the user mistypes #3860

Merged
merged 2 commits into from May 13, 2019

Conversation

Projects
None yet
3 participants
@jamesgeorge007
Copy link
Contributor

commented Apr 22, 2019

Suggest appropriate commands if the user mistypes utilising the didyoumean package.

@jamesgeorge007 jamesgeorge007 force-pushed the jamesgeorge007:feat/suggest-commands branch from e06355b to e852855 Apr 22, 2019

@sodatea

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

Thanks for the PR! I like the idea 😀
Will check it later.

@jamesgeorge007 jamesgeorge007 changed the title Suggest matching commands if the user mistypes feat(cli): Suggest matching commands if the user mistypes Apr 28, 2019

Show resolved Hide resolved packages/@vue/cli/bin/vue.js Outdated
Show resolved Hide resolved packages/@vue/cli/bin/vue.js Outdated
@jamesgeorge007

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

@sodatea Thoughts 🤔

Show resolved Hide resolved packages/@vue/cli/bin/vue.js Outdated

@jamesgeorge007 jamesgeorge007 force-pushed the jamesgeorge007:feat/suggest-commands branch from d89c17c to 402bc46 May 13, 2019

Show resolved Hide resolved packages/@vue/cli/bin/vue.js Outdated

@jamesgeorge007 jamesgeorge007 force-pushed the jamesgeorge007:feat/suggest-commands branch from 077624c to 17c25ba May 13, 2019

@jamesgeorge007

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

@sodatea Hope everythings fine now 😅

@sodatea sodatea changed the title feat(cli): Suggest matching commands if the user mistypes feat(cli): suggest matching commands if the user mistypes May 13, 2019

@sodatea sodatea merged commit ab18cd5 into vuejs:dev May 13, 2019

7 checks passed

ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@vue-bot

This comment has been minimized.

Copy link

commented May 13, 2019

Hey @jamesgeorge007, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

sodatea added a commit that referenced this pull request May 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.