Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prefer .tsx? files over .jsx? file extensions #3909

Merged
merged 1 commit into from May 3, 2019

Conversation

Projects
None yet
2 participants
@LinusBorg
Copy link
Member

commented Apr 29, 2019

When using Typescript, the webpack resolve options should prefer ts? file extensions over js? ones.

Strictly speaking, this is a breaking change, so we can ship this with v4 I think.

close #3898

@LinusBorg LinusBorg changed the title prefer ts files over js prefer .tsx? files over .jsx? file extensions Apr 29, 2019

@LinusBorg LinusBorg marked this pull request as ready for review May 3, 2019

@LinusBorg

This comment has been minimized.

Copy link
Member Author

commented May 3, 2019

@sodatea I think this is a small optimization that we can still add to v4, no?

@LinusBorg LinusBorg requested a review from sodatea May 3, 2019

@sodatea

This comment has been minimized.

Copy link
Member

commented May 3, 2019

Yeah I think so

@sodatea

sodatea approved these changes May 3, 2019

@sodatea sodatea changed the title prefer .tsx? files over .jsx? file extensions chore: prefer .tsx? files over .jsx? file extensions May 3, 2019

@sodatea sodatea merged commit 0c635af into dev May 3, 2019

7 of 8 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

sodatea added a commit that referenced this pull request May 25, 2019

sodatea added a commit that referenced this pull request May 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.