Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbnb lint should not warn on vuex state mutation #3961

Merged
merged 3 commits into from Jun 13, 2019

Conversation

Projects
None yet
2 participants
@LinusBorg
Copy link
Member

commented May 8, 2019

@LinusBorg LinusBorg force-pushed the LinusBorg-patch-2 branch from 77309d3 to 9041497 May 16, 2019

@LinusBorg LinusBorg force-pushed the LinusBorg-patch-2 branch from 9041497 to dc9486c May 16, 2019

@LinusBorg LinusBorg marked this pull request as ready for review May 16, 2019

Show resolved Hide resolved packages/@vue/cli/__tests__/invoke.spec.js Outdated

@LinusBorg LinusBorg self-assigned this May 17, 2019

@sodatea

This comment has been minimized.

Copy link
Member

commented May 21, 2019

Just realized this config can be added to @vue/eslint-config-airbnb rather than the eslint plugin… And tests are not mandatory for config packages.

@LinusBorg

This comment has been minimized.

Copy link
Member Author

commented May 29, 2019

Understood, will make the changes

@LinusBorg LinusBorg removed their assignment Jun 1, 2019

@LinusBorg

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2019

@sodatea I moved the change to the config-aribnb package as discussed.

Though technically this could be considered a breaking change if we are very picky.

@sodatea

sodatea approved these changes Jun 1, 2019

@sodatea

This comment has been minimized.

Copy link
Member

commented Jun 1, 2019

Why?
In regard to ESLint configs, it is only a breaking change when it breaks people's builds. But loosening a rule won't cause more build failures.

@LinusBorg

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2019

In that regard I agree.

If someone is pedantic about what kind of code is committed, they now have a rule pass that might have failed before.

But I agree that's so minimal, especially in the context of the change, we can discard it.

@sodatea sodatea merged commit cb47a28 into dev Jun 13, 2019

8 checks passed

ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@sodatea sodatea added the PR: Bug Fix label Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.