Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade fiber to support node@12 #4109

Closed
wants to merge 2 commits into from

Conversation

renfeng
Copy link

@renfeng renfeng commented Jun 5, 2019

@sodatea
Copy link
Member

sodatea commented Jun 13, 2019

Thanks for this PR. But I don't think this change makes any difference.
And since we may need to test on Node.js v8, it's better to continue allowing fibers@3 as a devDependency.

@sodatea sodatea closed this Jun 13, 2019
@renfeng
Copy link
Author

renfeng commented Jun 13, 2019

It breaks the build process for projects that depend on it! Can you read this, and reopen it? Thanks

@sodatea
Copy link
Member

sodatea commented Jun 13, 2019

Could you provide a reproduction?
I don't think it will break any build.

  1. It's in devDependencies, won't be installed for those who depend on it.
  2. The range >= 3.1.1 <5.0.0 does resolve to 4.0.1 in environments that support fibers@4.x. See the lockfile:

    vue-cli/yarn.lock

    Lines 7018 to 7023 in ab97f31

    "fibers@>= 3.1.1 <5.0.0":
    version "4.0.1"
    resolved "https://registry.yarnpkg.com/fibers/-/fibers-4.0.1.tgz#34fe8a8d010db7f9096adb2558a45bbc1d03fe45"
    integrity sha512-H79EJn7DMWXk48ygmC82bMP8KNcFBZF1CPfwBpYF6cO85hGWoIrlu7eyX9ayxfjP9Nsl0JXxdI6fpYU4DWVw2w==
    dependencies:
    detect-libc "^1.0.3"
    Your PR won't make any difference here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants