Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make webpack `use` values consistent #4230

Merged
merged 1 commit into from Jul 14, 2019

Conversation

@shadow-light
Copy link
Contributor

shadow-light commented Jul 3, 2019

The use key is pug-plain despite a similar item above it using the key pug-plain-loader. This just makes them consistent.

This has a small chance of breaking projects that already override that particular loader config. So feel free to ignore this if it isn't worth it.

The use key is `pug-plain` despite a similar item above it using the key `pug-plain-loader`. This just makes them consistent.

This has a small chance of breaking projects that already override that particular loader config. So feel free to ignore this if it isn't worth it.
@LinusBorg

This comment has been minimized.

Copy link
Member

LinusBorg commented Jul 14, 2019

@sodatea Technically, this is a breaking change as people might hook into this config setting in existing projects.

It's a simple enough fix to put it into v4 though, I think.

@sodatea you agree?

@sodatea

This comment has been minimized.

Copy link
Member

sodatea commented Jul 14, 2019

Yeah I think so.

@sodatea sodatea merged commit 52ae1c8 into vuejs:dev Jul 14, 2019
7 checks passed
7 checks passed
ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@vue-bot

This comment has been minimized.

Copy link

vue-bot commented Jul 14, 2019

Hey @shadow-light, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.