Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade webpack #4253

Merged
merged 3 commits into from
Aug 12, 2019
Merged

feat: upgrade webpack #4253

merged 3 commits into from
Aug 12, 2019

Conversation

DRoet
Copy link
Contributor

@DRoet DRoet commented Jul 9, 2019

Now that webpack/webpack#8656 has been resolved in the latest webpack release, I believe the version range restriction can finally be removed.

Should the updated .lock file be commited aswell?

@sodatea
Copy link
Member

sodatea commented Jul 9, 2019

Better use ^4.0.0 as there might be other plugins in the ecosystem also has this version restriction, forcing the latest version may result in failing dependency deduping.

We do lockfile maintenance regularly so no need to commit it in PRs.

@DRoet
Copy link
Contributor Author

DRoet commented Jul 9, 2019

@sodatea done

@sodatea
Copy link
Member

sodatea commented Jul 10, 2019

Will merge this after fixing the failing tests.
For now, I've narrowed it down to this commit in webpack: webpack/webpack#8917

@sodatea
Copy link
Member

sodatea commented Aug 8, 2019

😅Just found out that both webpack & preload-webpack-plugin are doing it right. It's html-webpack-plugin that adds the unused chunk-common chunk to the html file…
I'll fix the test cases.

only test pages that do share a common chunk
@sodatea sodatea merged commit 428d172 into vuejs:dev Aug 12, 2019
@vue-bot
Copy link

vue-bot commented Aug 12, 2019

Hey @DRoet, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

sodatea pushed a commit that referenced this pull request Aug 21, 2019
(cherry picked from commit 428d172)
@DRoet DRoet deleted the upgrade-webpack branch September 25, 2019 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants