Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade webpack #4253

Merged
merged 3 commits into from Aug 12, 2019

Conversation

@DRoet
Copy link
Contributor

commented Jul 9, 2019

Now that webpack/webpack#8656 has been resolved in the latest webpack release, I believe the version range restriction can finally be removed.

Should the updated .lock file be commited aswell?

@sodatea

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Better use ^4.0.0 as there might be other plugins in the ecosystem also has this version restriction, forcing the latest version may result in failing dependency deduping.

We do lockfile maintenance regularly so no need to commit it in PRs.

@DRoet DRoet force-pushed the DRoet:upgrade-webpack branch from 2ddbdc0 to 276ea14 Jul 9, 2019

@DRoet

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

@sodatea done

@sodatea

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

Will merge this after fixing the failing tests.
For now, I've narrowed it down to this commit in webpack: webpack/webpack#8917

@sodatea

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

😅Just found out that both webpack & preload-webpack-plugin are doing it right. It's html-webpack-plugin that adds the unused chunk-common chunk to the html file…
I'll fix the test cases.

test: fix common chunk test
only test pages that do share a common chunk
@sodatea

sodatea approved these changes Aug 8, 2019

@sodatea sodatea merged commit 428d172 into vuejs:dev Aug 12, 2019

7 checks passed

ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@vue-bot

This comment has been minimized.

Copy link

commented Aug 12, 2019

Hey @DRoet, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.