Skip to content

Conversation

posva
Copy link
Member

@posva posva commented Apr 1, 2017

Closes #422
This makes it easier to combine with the official webpack template

Closes vuejs#422
This makes it easier to combine with the official webpack template
@posva posva requested a review from egoist April 1, 2017 11:53
bin/vue-build Outdated
],
alias: {}
alias: {
'@': 'src'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should use absolute path? like cwd('src')

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better? I also wondered but since this worked I didn't add anything

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use an absolute path for this alias in the webpack template as well:

https://github.com/vuejs-templates/webpack/blob/master/template/build/webpack.base.conf.js#L27

/ping @posva

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot about this!

@LinusBorg
Copy link
Member

/ping @egoist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants