Add an alias from '@' to src #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes vuejs#422 This makes it easier to combine with the official webpack template
egoist
reviewed
Apr 1, 2017
bin/vue-build
Outdated
| @@ -150,7 +150,9 @@ var webpackConfig = { | |||
| cwd('node_modules'), // modules in cwd's node_modules | |||
| ownDir('node_modules') // modules in package's node_modules | |||
| ], | |||
| alias: {} | |||
| alias: { | |||
| '@': 'src' | |||
There was a problem hiding this comment.
should use absolute path? like cwd('src')
There was a problem hiding this comment.
Is it better? I also wondered but since this worked I didn't add anything
There was a problem hiding this comment.
We use an absolute path for this alias in the webpack template as well:
https://github.com/vuejs-templates/webpack/blob/master/template/build/webpack.base.conf.js#L27
/ping @posva
|
/ping @egoist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #422
This makes it easier to combine with the official webpack template