Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: deprecate css.modules in favor of css.requireModuleExtension #4387

Merged
merged 2 commits into from Aug 2, 2019

Conversation

@sodatea
Copy link
Member

@sodatea sodatea commented Aug 1, 2019

closes #4376

Since css-loader v3, custom CSS Modules configurations are under the
modules field. So when a user customizes these configurations, the modules
feature is automatically enabled for all css files.
So we must require the user's explicit consensus or disagreement on whether
these rules apply to all CSS files or not.

closes vuejs#4376

Since css-loader v3, cutom css modules configurations are under the
`modules` field. So when user customize these configurations, `modules`
feature is automatically enabled for all css files.
So we must require user's explicit consensus or disagreement on whether
these rules apply to all CSS files or not.
@sodatea
Copy link
Member Author

@sodatea sodatea commented Aug 1, 2019

/cc @Maorey
I suppose this option can finally solve your problem?

Loading

@sodatea sodatea merged commit e9fd9a7 into vuejs:dev Aug 2, 2019
7 of 8 checks passed
Loading
@sodatea sodatea deleted the requireModuleExtension branch Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant