feat!: deprecate css.modules in favor of css.requireModuleExtension#4387
Merged
haoqunjiang merged 2 commits intovuejs:devfrom Aug 2, 2019
Merged
feat!: deprecate css.modules in favor of css.requireModuleExtension#4387haoqunjiang merged 2 commits intovuejs:devfrom
css.modules in favor of css.requireModuleExtension#4387haoqunjiang merged 2 commits intovuejs:devfrom
Conversation
closes vuejs#4376 Since css-loader v3, cutom css modules configurations are under the `modules` field. So when user customize these configurations, `modules` feature is automatically enabled for all css files. So we must require user's explicit consensus or disagreement on whether these rules apply to all CSS files or not.
Member
Author
|
/cc @Maorey |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4376
Since css-loader v3, custom CSS Modules configurations are under the
modulesfield. So when a user customizes these configurations, themodulesfeature is automatically enabled for all css files.
So we must require the user's explicit consensus or disagreement on whether
these rules apply to all CSS files or not.