fix: eslint should override env for **/tests/** subfolders
#4447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for **/tests/** subfolders close #4397
haoqunjiang
reviewed
Aug 20, 2019
haoqunjiang
approved these changes
Aug 21, 2019
haoqunjiang
changed the title
haoqunjiang
changed the title
**/tests/** subfolders
haoqunjiang
pushed a commit
that referenced
this pull request
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
The unit test packages support tests in /tests/unit and */__tests__/ folders, but eslint config for jest/mocha was only applied to the former
This PR adds overrides to the eslint config for files in the latter type of folder so eslint can successfully detect and lint jest/mocha globals