Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli-plugin-babel): roperly exports the babel preset #4533

Merged
merged 2 commits into from Sep 2, 2019

Conversation

@arcanis
Copy link
Contributor

commented Aug 31, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix

Does this PR introduce a breaking change? (check one)

  • No

Other information:

The current setup relies on the hoisting for babel.config.js to be able to access @vue/babel-preset-app, since it's not actually part of the package dependencies. This change re-exports it from @vue/cli-plugin-babel, which is an actual dependency.

Ref yarnpkg/berry#368

@sodatea

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

Thanks for the help! But this change failed our tests. Would you please also change the corresponding test case for this feature?

@sodatea
sodatea approved these changes Sep 2, 2019

@sodatea sodatea merged commit be0cb95 into vuejs:dev Sep 2, 2019

6 of 7 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
@vue-bot

This comment has been minimized.

Copy link

commented Sep 2, 2019

Hey @arcanis, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.