Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nightwatch): check user's installed browser versions on scaffolding / before running tests #4563

Merged
merged 4 commits into from Sep 12, 2019

Conversation

@sodatea
Copy link
Member

commented Sep 10, 2019

  1. By checking for firefox installation, users can save the bandwith of
    downloading the geckodriver package if they don't need it;
  2. By detecting installed Chrome version, even if we failed to closely
    follow up chromedriver's releases, users can still get the correct
    version they need;
  3. By comparing user's Chrome version with the installed chromedriver
    version and output warnings, users can have a basic knowledge of what
    actions to take if they accidentally updated to an incompatible
    version of Chrome.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

sodatea added 3 commits Sep 10, 2019
feat(nightwatch): check user's installed browser versions on scaffold…
…ing / before running tests

1. By checking for firefox installation, users can save the bandwith of
downloading the geckodriver package if they don't need it;
2. By detecting installed Chrome version, even if we failed to closely
follow up chromedriver's releases, users can still get the correct
version they need;
3. By comparing user's Chrome version with the installed chromedriver
version and output warnings, users can have a basic knowledge of what
actions to take if they accidentally updated to an incompatible
version of Chrome.

@sodatea sodatea merged commit 0473432 into vuejs:dev Sep 12, 2019

7 checks passed

ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.