feat(nightwatch): check user's installed browser versions on scaffolding / before running tests #4563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing / before running tests 1. By checking for firefox installation, users can save the bandwith of downloading the geckodriver package if they don't need it; 2. By detecting installed Chrome version, even if we failed to closely follow up chromedriver's releases, users can still get the correct version they need; 3. By comparing user's Chrome version with the installed chromedriver version and output warnings, users can have a basic knowledge of what actions to take if they accidentally updated to an incompatible version of Chrome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
downloading the geckodriver package if they don't need it;
follow up chromedriver's releases, users can still get the correct
version they need;
version and output warnings, users can have a basic knowledge of what
actions to take if they accidentally updated to an incompatible
version of Chrome.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: