Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: upgrade terser-webpack-plugin to 2.x #4676

Merged
merged 1 commit into from Oct 11, 2019

Conversation

@sodatea
Copy link
Member

sodatea commented Oct 11, 2019

BREAKING CHANGE:
The only real breaking change is webpack-contrib/terser-webpack-plugin#129,
which is not likely to affect normal users.

The rest is default option values changes, which are already covered in
the default provided terserOptions of Vue CLI.

Note that here we choose to disable extractComments by default, as I
don't see enough data showing such license comments taking too much
space. The extra LICENSE file may also be confusing to some users.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

BREAKING CHANGE:
The only real breaking change is webpack-contrib/terser-webpack-plugin#129,
which is not likely to affect normal users.

The rest are default option values changes, which are already covered in
the default provided `terserOptions` of Vue CLI.

Note that here we choose to disable `extractComments` by default, as I
don't see enough data showing such license comments taking too much
space. The extra LICENSE file may also be confusing to some users.
@sodatea sodatea merged commit 08d7761 into vuejs:dev Oct 11, 2019
7 checks passed
7 checks passed
ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@sodatea sodatea deleted the sodatea:feat-upgrade-terser-plugin branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.