Skip to content

fix: add a compatibility layer for router & vuex for CLI v3 #4693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2019
Merged

fix: add a compatibility layer for router & vuex for CLI v3 #4693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions packages/@vue/cli-service/generator/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
const { execa } = require('@vue/cli-shared-utils')

module.exports = (api, options) => {
api.render('./template', {
doesCompile: api.hasPlugin('babel') || api.hasPlugin('typescript')
Expand Down Expand Up @@ -54,6 +56,43 @@ module.exports = (api, options) => {
})
}

// for v3 compatibility
if (options.router && !api.hasPlugin('router')) {
api.extendPackage({
devDependencies: {
'@vue/cli-plugin-router': '^4.0.0'
}
})

api.onCreateComplete(() => {
execa.sync('vue', [
'invoke',
'@vue/cli-plugin-router',
`--historyMode=${options.routerHistoryMode ? 'true' : ''}`
], {
cwd: api.resolve('.')
})
})
}

// for v3 compatibility
if (options.vuex && !api.hasPlugin('vuex')) {
api.extendPackage({
devDependencies: {
'@vue/cli-plugin-vuex': '^4.0.0'
}
})

api.onCreateComplete(() => {
execa.sync('vue', [
'invoke',
'@vue/cli-plugin-vuex'
], {
cwd: api.resolve('.')
})
})
}

// additional tooling configurations
if (options.configs) {
api.extendPackage(options.configs)
Expand Down