Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docs `css.loaderOptions.css.localsConvention` #4803

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@negibouze
Copy link

negibouze commented Nov 6, 2019

Moved 'localsConvention' to the same level as 'modules'.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:
I only tested on macOS.

logs from css-loader's

[Function: validate] {
  schema: {
    additionalProperties: false,
    properties: {
      url: [Object],
      import: [Object],
      modules: [Object],
      sourceMap: [Object],
      importLoaders: [Object],
      localsConvention: [Object],
      onlyLocals: [Object]
    },
    type: 'object'
  },
  errors: null,
  refs: {},
  refVal: [ [Circular] ],
  root: [Circular]
}
Moved 'localsConvention' to the same level as 'modules'.
@sodatea
sodatea approved these changes Nov 6, 2019
@sodatea sodatea merged commit 77384ec into vuejs:master Nov 6, 2019
8 checks passed
8 checks passed
ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
deploy/netlify Deploy preview ready!
Details
@vue-bot

This comment has been minimized.

Copy link

vue-bot commented Nov 6, 2019

Hey @negibouze, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.