Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single websocket connection for HMR #5069

Merged
merged 3 commits into from Jan 13, 2020
Merged

Conversation

@lbogdan
Copy link
Contributor

lbogdan commented Jan 10, 2020

Fixes #4947 , see that for details.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No
@lbogdan lbogdan force-pushed the lbogdan:fix/hmr-websocket branch from bf6cbf2 to d8eb35e Jan 10, 2020
@lbogdan

This comment has been minimized.

Copy link
Contributor Author

lbogdan commented Jan 10, 2020

This should be ready for review.

Things I'm not 100% sure:

  • how to expose puppeteer's network request URLs to the tests;
  • looking at 'sockjs-node' http requests, which is a webpack-dev-server implementation detail. I've tried looking for websocket connections (the http request I look for only returns the websocket options), unfortunately websocket requests don't trigger page.on('request').
@lbogdan lbogdan marked this pull request as ready for review Jan 10, 2020
@lbogdan lbogdan force-pushed the lbogdan:fix/hmr-websocket branch from d8eb35e to d2045b9 Jan 10, 2020
@sodatea sodatea added the PR: Bug Fix label Jan 13, 2020
@sodatea sodatea merged commit 7b17d61 into vuejs:dev Jan 13, 2020
6 of 7 checks passed
6 of 7 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.