Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should infer package manager from config if there's no lockfile in the project #5150

Merged
merged 2 commits into from Feb 6, 2020

Conversation

@sodatea
Copy link
Member

sodatea commented Feb 6, 2020

Fixed monorepo use cases.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

…in the project
…ckfile in the project
@sodatea sodatea merged commit 51a4da7 into dev Feb 6, 2020
8 checks passed
8 checks passed
ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@sodatea sodatea deleted the monorepo-packagemanager branch Feb 6, 2020
@@ -88,8 +89,17 @@ class PackageManager {
if (forcePackageManager) {

This comment has been minimized.

Copy link
@Akryum

Akryum Feb 6, 2020

Member

How do we force the package manager?

This comment has been minimized.

Copy link
@sodatea

sodatea Feb 6, 2020

Author Member

The -m / --packageManager option of vue create. Maybe we should add this option for vue add and vue invoke too?

return true
}

const lockFile = path.join(cwd, 'package-lock.json')

This comment has been minimized.

Copy link
@Akryum

Akryum Feb 6, 2020

Member

Maybe we should use findup?

This comment has been minimized.

Copy link
@sodatea

sodatea Feb 6, 2020

Author Member

Yeah that makes more sense.

mactanxin added a commit to mactanxin/vue-cli that referenced this pull request Feb 11, 2020
…in the project (vuejs#5150)

* fix: should infer package manager from config if there's no lockfile in the project

* fixup! fix: should infer package manager from config if there's no lockfile in the project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.