Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ease the default `no-console` severity to `warn` #5241

Merged
merged 1 commit into from Mar 19, 2020

Conversation

@sodatea
Copy link
Member

sodatea commented Mar 4, 2020

As ESLint 6 removes this rule from the recommended config
https://eslint.org/docs/user-guide/migrating-to-6.0.0#eslint-recommended-has-been-updated

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

As ESLint 6 removes this rule from the recommended config
https://eslint.org/docs/user-guide/migrating-to-6.0.0#eslint-recommended-has-been-updated
Copy link
Member

LinusBorg left a comment

Makes sense!

@sodatea sodatea merged commit 41cf5e1 into vuejs:dev Mar 19, 2020
7 checks passed
7 checks passed
ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@sodatea sodatea deleted the sodatea:no-console-as-warn branch Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.