Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unit-jest, unit-mocha): generate passing tests when bare option is used with router enabled (#3544) #5591

Merged
merged 2 commits into from Sep 7, 2020

Conversation

@IwalkAlone
Copy link
Contributor

@IwalkAlone IwalkAlone commented Jun 17, 2020

Fixes: #3544

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

… is used with router enabled (#3544)
@sodatea
sodatea approved these changes Sep 3, 2020
Copy link
Member

@sodatea sodatea left a comment

Looks good to me.

Could you please fix the merge conflicts so that we can merge the PR?

@IwalkAlone
Copy link
Contributor Author

@IwalkAlone IwalkAlone commented Sep 6, 2020

Looks good to me.

Could you please fix the merge conflicts so that we can merge the PR?

@sodatea Done

@sodatea sodatea merged commit d6e493d into vuejs:dev Sep 7, 2020
7 checks passed
7 checks passed
ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants