Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable some syntax extensions by default for vue script compiler #5868

Merged
merged 1 commit into from Sep 10, 2020

Conversation

@sodatea
Copy link
Member

@sodatea sodatea commented Sep 10, 2020

These are enabled by default in the @vue/babel-preset-app.

Fixes #5863
Fixes #5866

This don't fix the case where the user has enabled more custom syntax in
babel. @vue/compiler-sfc needs to fail gracefully in such cases.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

These are enabled by default in the `@vue/babel-preset-app`.

Fixes #5863
Fixes #5866

These doesn't fix the case where user has enabled more custom syntax in
babel. `@vue/compiler-sfc` needs to fail gracefully in such cases.
@sodatea sodatea merged commit 9e5b16b into vuejs:dev Sep 10, 2020
7 checks passed
7 checks passed
ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@sodatea sodatea deleted the sodatea:fix-script-setup branch Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant