Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: drop support of NPM 5 #6051

Merged
merged 1 commit into from
Nov 14, 2020
Merged

Conversation

sodatea
Copy link
Member

@sodatea sodatea commented Nov 13, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

@fangbinwei
Copy link
Collaborator

fangbinwei commented Nov 13, 2020

engines field of @vue/cli, @vue/cli-service also needs to be modified? And the original npm version of Node.js 10.16.0 is 6.9.0.

"engines": {
"node": ">=8.9"
}

I am testing @babel/eslint-parser and eslint7 recently, and eslint7 requires nodejs ^10.12.0, or >=12.0.0. Maybe it should be considered ?

@sodatea
Copy link
Member Author

sodatea commented Nov 13, 2020

Yeah right, I'll bump it in a separate PR.

@sodatea sodatea merged commit 66a87f2 into vuejs:dev Nov 14, 2020
@sodatea sodatea deleted the chore-optional-dep branch November 14, 2020 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants