Skip to content

Conversation

haoqunjiang
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

@fangbinwei
Copy link
Collaborator

fangbinwei commented Nov 13, 2020

engines field of @vue/cli, @vue/cli-service also needs to be modified? And the original npm version of Node.js 10.16.0 is 6.9.0.

"engines": {
"node": ">=8.9"
}

I am testing @babel/eslint-parser and eslint7 recently, and eslint7 requires nodejs ^10.12.0, or >=12.0.0. Maybe it should be considered ?

@haoqunjiang
Copy link
Member Author

Yeah right, I'll bump it in a separate PR.

@haoqunjiang haoqunjiang merged commit 66a87f2 into vuejs:dev Nov 14, 2020
@haoqunjiang haoqunjiang deleted the chore-optional-dep branch November 14, 2020 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants