Skip to content

fix(cli-plugin-typescript): remove getPrompts function in prompts.js #6053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2020
Merged

fix(cli-plugin-typescript): remove getPrompts function in prompts.js #6053

merged 1 commit into from
Nov 14, 2020

Conversation

jeneser
Copy link
Contributor

@jeneser jeneser commented Nov 13, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

TSLint options have been removed. #5065 getPrompts would break convertJsToTs prompt. #2676

@jeneser jeneser mentioned this pull request Nov 13, 2020
Closed
haoqunjiang
haoqunjiang approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@haoqunjiang haoqunjiang merged commit cb5f117 into vuejs:dev Nov 14, 2020
@haoqunjiang haoqunjiang mentioned this pull request Nov 14, 2020
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
PR: Internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeneser @haoqunjiang