Skip to content

Conversation

fangbinwei
Copy link
Collaborator

@fangbinwei fangbinwei commented Nov 15, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:
replace babel-eslint with @babel/eslint-parser, bump eslint to ^7.13.0
close #5734 and #5981

@fangbinwei
Copy link
Collaborator Author

fangbinwei commented Nov 16, 2020

It seems @vue/cli-plugin-eslint/lint.js break in test, will check later.
it can run correctly by executing vue invoke eslint manually

related to how @babel/core loadConfig
maybe related babel/babel#11975

Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@babel/core is a peer dependency of @babel/eslint-parser, we need to explicitly install it into the user project.
Implicitly depending on package hoisting may break some package managers.

Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Now please merge from the dev branch. I just updated yarn.lock and now there's a merge conflict here.

@haoqunjiang haoqunjiang merged commit 9136696 into vuejs:dev Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use @babel/eslint-parser instead of babel-eslint
2 participants