Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: webpack-bundle-analyzer to ^4.1.0 #6092

Merged
merged 3 commits into from
Dec 2, 2020
Merged

chore: webpack-bundle-analyzer to ^4.1.0 #6092

merged 3 commits into from
Dec 2, 2020

Conversation

genie-youn
Copy link
Contributor

@genie-youn genie-youn commented Nov 28, 2020

Fixes: #6091

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe: upgrade dependency webpack-bundle-analyzer to ^4.1.0

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

@@ -63,6 +63,43 @@ test('build', async () => {
expect(h1Text).toMatch('Welcome to Your Vue.js App')
})

test('build with --report-json', async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If don't need this test, I'll delete it.

Copy link
Member

@sodatea sodatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The test also looks good to me!

@sodatea sodatea merged commit 928f915 into vuejs:dev Dec 2, 2020
@kwongiho
Copy link

kwongiho commented Dec 4, 2020

LGTM👍

@hyesun03
Copy link

hyesun03 commented Dec 7, 2020

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update webpack-bundle-analyzer to ^4.1.0
4 participants