Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add mssing argument in getCacheKey #153

Merged
merged 1 commit into from
Jan 28, 2019
Merged

fix: add mssing argument in getCacheKey #153

merged 1 commit into from
Jan 28, 2019

Conversation

clarkdo
Copy link
Contributor

@clarkdo clarkdo commented Jan 28, 2019 •
edited
Loading

Upgrade to vue-jest to 4.0.0-beta failed since babel-jest introduced config in getCacheKey https://github.com/facebook/jest/blob/master/packages/babel-jest/src/index.js#L53

@eddyerburgh Could you give me a review and trigger a new release ?

@clarkdo clarkdo mentioned this pull request Jan 28, 2019
Merged
7 tasks
eddyerburgh
eddyerburgh approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@eddyerburgh eddyerburgh merged commit 379490f into vuejs:master Jan 28, 2019
@eddyerburgh
Copy link
Member

I've released this in 4.0.0-beta.1

@clarkdo
Copy link
Contributor Author

clarkdo commented Jan 29, 2019

thank you for your quick response 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyerburgh eddyerburgh eddyerburgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clarkdo @eddyerburgh