Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit existing queries #1330

Merged
merged 6 commits into from
Jun 4, 2018
Merged

Conversation

privatenumber
Copy link

@privatenumber privatenumber commented May 29, 2018

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
I am working on a loader that compiles markdown into a Vue component and also extracts all Vue code-blocks into demos. I do this by creating a mddemo-loader that extracts the particular demo by an index passed into the query (eg. idx=0). The output of this loader is piped into vue-loader. However, vue-loader currently doesn't inherit the existing queries so the mddemo-loader doesn't get applied (via webpack config) and the entire markdown is gets parsed when vue-loader tries to extract the template and script tags of a particular demo in the markdown file.

@yyx990803
Copy link
Member

Can you add a test case for this?

@privatenumber
Copy link
Author

@yyx990803 Added!

@yyx990803 yyx990803 merged commit 0f0b09b into vuejs:master Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants