Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vue-loader: 11.3.4 → 12.0.0 breaks <style lang="scss"> #790

Closed
bentolor opened this issue Apr 26, 2017 · 2 comments
Closed

vue-loader: 11.3.4 → 12.0.0 breaks <style lang="scss"> #790

bentolor opened this issue Apr 26, 2017 · 2 comments

Comments

@bentolor
Copy link

Version

12.0.0

Reproduction link

Can't reproduce a build problem

Steps to reproduce

After upgrading my vue-loader dependency from 11.3.4 to 12.0.0 the `<style lang="scss"> does no longer work.

I'm using the latest vue-cli webpack template with the following added to webpack.base.conf

      {
        test: /\.scss$/,
        loaders: [ 'style', 'css', 'sass' ]
      },

What is expected?

It should work as previously.

What is actually happening?

ERROR  Failed to compile with 1 errors                                                                                                                 19:16:22

 error  in ./src/App.vue

Module build failed: 
.wrapper {
         ^
      Invalid CSS after ".wrapper {": expected "}", was "{"
      in /home/ben/projects/mfusst-ui.git/app/src/App.vue (line 18, column 11)

 @ ./~/vue-style-loader!./~/css-loader?{"minimize":false,"sourceMap":false}!./~/vue-loader/lib/style-compiler?{"vue":true,"id":"data-v-bd26cd6c","scoped":false,"hasInlineConfig":false}!./~/sass-loader/lib/loader.js?{"indentedSyntax":true,"sourceMap":false}!./~/vue-loader/lib/selector.js?type=styles&index=0!./src/App.vue 4:14-404 13:3-17:5 14:22-412
 @ ./src/App.vue
 @ ./src/main.js
 @ multi ./build/dev-client ./src/main.js
@TheLarkInn
Copy link

Am also seeing this as well. @yyx990803 let me know if you need some reproducibles.

@yyx990803
Copy link
Member

Fixed in 12.0.1!

yyx990803 pushed a commit that referenced this issue Apr 28, 2017
* update Chinese translation

* Do not consider private properties to be named exports (fix: #759) (#765)

* support deps registered by postcss plugins

* make keyframes scoped (close #731)

* only infer scss/sass loader when no explicit loaders have been specified (fix #790)

* 12.0.1

* Revert "make keyframes scoped (close #731)"

This reverts commit 35229b0.

* 12.0.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants