Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject-Loader 3.0.0 warning is out of date #892

Closed
joflashstudios opened this issue Jul 17, 2017 · 1 comment
Closed

Inject-Loader 3.0.0 warning is out of date #892

joflashstudios opened this issue Jul 17, 2017 · 1 comment

Comments

@joflashstudios
Copy link

Version

12.2.2

Reproduction link

https://vue-loader.vuejs.org/en/workflow/testing-with-mocks.html

Steps to reproduce

The documentation states that Inject-Loader 3.0.0 is unstable (circa September 2016), but 3.0.0 has been out of beta since March 2017, so it seems like this warning is out of date.

What is expected?

No warning about inject-loader 3.0.0

What is actually happening?

Warning about inject-loader 3.0.0

@Jinjiang
Copy link
Member

Jinjiang commented Dec 9, 2017

I think the warning could be removed. Also I found another important warning: disabling esModule option in inject mode because import/export must be top-level.

I will create a PR for this soon.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants