Skip to content

Fix inconsistent path between Windows and POSIX systems‏ #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2018
Merged

Fix inconsistent path between Windows and POSIX systems‏ #1384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
852ff90
Fix inconsistent path between Windows and POSIX systems
sharkykh Aug 7, 2018
f3020ad
Fix test
sharkykh Aug 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ var component = normalizer(
? JSON.stringify(filename)
// Expose the file's full path in development, so that it can be opened
// from the devtools.
: JSON.stringify(rawShortFilePath)
: JSON.stringify(rawShortFilePath.replace(/\\/g, '/'))
}`

code += `\nexport default component.exports`
Expand Down
3 changes: 1 addition & 2 deletions test/advanced.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
const path = require('path')
const { SourceMapConsumer } = require('source-map')
const normalizeNewline = require('normalize-newline')
const MiniCssExtractPlugin = require('mini-css-extract-plugin')
Expand Down Expand Up @@ -50,7 +49,7 @@ test('expose file path as __file outside production', done => {
mockBundleAndRun({
entry: 'basic.vue'
}, ({ module }) => {
expect(module.__file).toBe(path.normalize('test/fixtures/basic.vue'))
expect(module.__file).toBe('test/fixtures/basic.vue')
done()
})
})
Expand Down