Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses require.resolve #1585

Merged
merged 1 commit into from Sep 2, 2019

Conversation

@arcanis
Copy link
Contributor

commented Aug 31, 2019

Similar to vuejs/vue-cli#4532 - third-parties declaring loaders are strongly advised to use require.resolve to ensure they correctly reference their own dependencies.

@sodatea
sodatea approved these changes Sep 2, 2019

@sodatea sodatea merged commit d3fa467 into vuejs:master Sep 2, 2019

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
deploy/netlify Deploy preview ready!
Details
@vue-bot

This comment has been minimized.

Copy link

commented Sep 2, 2019

Hey @arcanis, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.