Skip to content

fix(runtime-core): only render valid slot content #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 26, 2020
Merged

fix(runtime-core): only render valid slot content #2485

merged 3 commits into from
Nov 26, 2020
+51 −6

Conversation

HcySunYang
Copy link
Member

@HcySunYang HcySunYang commented Oct 26, 2020 •
edited by posva
Loading

close: #2347
close #2461

@yyx990803 yyx990803 merged commit ce4915d into vuejs:master Nov 26, 2020
yyx990803 pushed a commit that referenced this pull request Dec 3, 2020
@edison1105
fix(runtime-core): skip patchBlockChildren if n1.dynamicChildren is n…
c59897c 
…ull (#2717)

fix #2715 

The bug was introduced by #2485 where a compiled slot may result in a bailed Fragment
which then gets its dynamicChildren set to `null` by the renderer.
@SimonaliaChen SimonaliaChen mentioned this pull request Dec 6, 2020
Merged
@Hfutsora Hfutsora mentioned this pull request Feb 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fallback slot content not rendered in nested component with slot Any content prevents slot component using default value
2 participants
@HcySunYang @yyx990803