Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-sfc): scope Id should not be attached to the Rules in the keyframes #3308

Merged
merged 1 commit into from
Mar 19, 2021
Merged

fix(compiler-sfc): scope Id should not be attached to the Rules in the keyframes #3308

merged 1 commit into from
Mar 19, 2021

Conversation

HcySunYang
Copy link
Member

Fix: #3304

@jonaskuske jonaskuske mentioned this pull request Feb 26, 2021
Closed
@mika76 mika76 mentioned this pull request Mar 2, 2021
Closed
@fangbinwei fangbinwei mentioned this pull request Mar 3, 2021
Closed
@dhruvkelawala
Copy link

Waiting for this commit to be merged 👀

@LinusBorg LinusBorg added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label Mar 8, 2021
@LinusBorg LinusBorg added this to Approved in Next Patch Mar 9, 2021
@yyyanghj yyyanghj mentioned this pull request Mar 14, 2021
Open
@lanmaomm
Copy link

Why not merge this commit for so long time since it's already approved?

@ArthurSuz
Copy link

Why not merge this commit for so long time since it's already approved?

I also encountered the same problem. I have been waiting for the new version to be released, but I wrote a plugin before the release to temporarily solve this problem.
try: https://www.npmjs.com/package/keyframes-scoped-fix

@HcySunYang
Copy link
Member Author

@knightly-bot build this

@knightly-bot
Copy link

Nightly Build

🌒 Knightly build enabled, release every night at 00:00 UTC (skip if no change)

📦 npm package

@HcySunYang
Copy link
Member Author

You can all use Knightly build until the PR is merged

@HcySunYang HcySunYang added ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. and removed 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Mar 19, 2021
@yyx990803 yyx990803 merged commit 6cb9475 into vuejs:master Mar 19, 2021
Next Patch automation moved this from Approved to Done Mar 19, 2021
@BeneStem
Copy link

Is this version already released?

@posva
Copy link
Member

posva commented Mar 24, 2021

Not yet

@LinusBorg LinusBorg moved this from Done to Final (Reviewed by Evan) in Next Patch Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusBorg LinusBorg LinusBorg approved these changes

@edison1105 edison1105 edison1105 approved these changes

Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Animations in scoped style blocks are broken
10 participants
@HcySunYang @dhruvkelawala @lanmaomm @ArthurSuz @knightly-bot @BeneStem @posva @LinusBorg @edison1105 @yyx990803