Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirection away from and back to route fails to cancel navigation #3133

Open
luxaritas opened this issue Feb 25, 2020 · 1 comment
Open

Redirection away from and back to route fails to cancel navigation #3133

luxaritas opened this issue Feb 25, 2020 · 1 comment
Labels
bug
Projects

Comments

@luxaritas
Copy link

@luxaritas luxaritas commented Feb 25, 2020

Version

3.1.3

Reproduction link

https://codepen.io/luxaritas/pen/WNvRagw?editors=1010

Steps to reproduce

  • Run a long async function within a route guard
  • Start at route A, navigate to route B, and then back to A again before the guard for B resolves

What is expected?

Navigation to route B is cancelled, or at least completed and re-routed to route A

What is actually happening?

NavigationDuplicated is thrown, and the page navigates to and stays on route B

@posva posva added the bug label Feb 25, 2020
@posva

This comment has been minimized.

Copy link
Member

@posva posva commented Feb 25, 2020

This could be technically a breaking change but I don't see a reason to not cancel ongoing navigation when trying to navigate to the same location

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Longterm
Awaiting triage
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.