Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(match): use pathMatch for the param of * routes #1995

Merged
merged 3 commits into from Jul 2, 2018
Merged

Conversation

@posva
Copy link
Member

@posva posva commented Jan 14, 2018

Fix #1994
Combining an asterisk route (*) with props: true would result in an
error because the name of the param would be the number 0 making it an
invalid attribute + the fact that vue passes props as attributes
if they're not declared as props

@posva posva requested a review from yyx990803 Jan 15, 2018
@posva posva added the bug label Feb 27, 2018
@posva posva added this to In progress in 3.x Apr 8, 2018
posva added 3 commits Apr 9, 2018
Fix #1994
Combining an asterisk route (*) with props: true would result in an
error because the name of the param would be the number 0 making it an
invalid attribute + the fact that vue passes props as attributes
if they're not declared as props
@posva posva force-pushed the fix/asterisk-props branch from 5343301 to 5edc2ec Apr 11, 2018
@posva posva moved this from In progress to Ready to review/merge in 3.x Apr 11, 2018
@posva posva changed the title fix(match): use fullPath for the param of * routes fix(match): use pathMatch for the param of * routes Apr 11, 2018
@skjnldsv
Copy link

@skjnldsv skjnldsv commented May 9, 2018

Bump?
I'm experiencing the same issue :/
Can I help @posva ?

Alternative fix: path: '/:index(index.php/)?settings/users',
Thanks to @danxuliu

export default new Router({
	mode: 'history',
	routes: [
		{
			path: '/(index.php/)?settings/users',
			component: Users,
			props: true,
			name: 'users',
			children: [
				{
					path: ':selectedGroup',
					name: 'group',
					component: Users
				}
			]
		}
	]
});

@posva posva merged commit ca1fccd into dev Jul 2, 2018
4 checks passed
@posva posva deleted the fix/asterisk-props branch Jul 2, 2018
@posva posva moved this from Ready to review/merge to Done in 3.x Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
3.x
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants