Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no warn if `pathMatch` is empty (fix #3072) #3081

Merged
merged 1 commit into from Dec 30, 2019
Merged

Conversation

@yinm
Copy link
Contributor

yinm commented Dec 26, 2019

Try to fix #3072
if pathMatch is empty, skip warning.

@yinm yinm marked this pull request as ready for review Dec 26, 2019
src/util/params.js Outdated Show resolved Hide resolved
@yinm yinm force-pushed the yinm:fix-pathMatch-warn branch from aac5049 to 590adbb Dec 27, 2019
@@ -24,9 +24,8 @@ export function fillParams (

return filler(params, { pretty: true })
} catch (e) {
if (process.env.NODE_ENV !== 'production') {

This comment has been minimized.

Copy link
@posva

posva Dec 27, 2019

Member

the if was necessary though

This comment has been minimized.

Copy link
@yinm

yinm Dec 27, 2019

Author Contributor

oops, I revert it

@yinm yinm force-pushed the yinm:fix-pathMatch-warn branch from 8a213d9 to 590adbb Dec 27, 2019
@posva
posva approved these changes Dec 30, 2019
Copy link
Member

posva left a comment

Thanks!

@posva posva merged commit ddc6bc7 into vuejs:dev Dec 30, 2019
6 checks passed
6 checks passed
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-flow-types Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-bs-ie9 Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
@yinm yinm deleted the yinm:fix-pathMatch-warn branch Dec 30, 2019
sthagen added a commit to sthagen/vue-router that referenced this pull request Jan 1, 2020
fix: suppress warning if `pathMatch` is empty (vuejs#3081)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.