feat(errors): capture errors thrown in redirect callback in onError #3251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulcabello
changed the title
posva
requested changes
Jul 3, 2020
|
Hi @posva ! Yes you are right, try catching router.match should be enough. I just thought it might be a good idea to also catch errors in the confirmTransition. |
try catch just router.match Resolves #3201
posva
reviewed
Jul 3, 2020
src/history/base.js
Outdated
| // https://github.com/vuejs/vue-router/issues/3201 | ||
| throw e | ||
| } | ||
| if (route) { |
There was a problem hiding this comment.
since we throw again if we fail, I don't think we need the if
There was a problem hiding this comment.
yes, I just removed it in a new commit
remove unnecessary if Resolves #3201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3201
This PR allows exceptions to be caught in router.onError.