Skip to content

docs: add type to the code of some md files #3460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2021
Merged

docs: add type to the code of some md files #3460

merged 2 commits into from
Jan 28, 2021

Conversation

FAKER-A
Copy link
Contributor

@FAKER-A FAKER-A commented Jan 27, 2021

Add type to the code of some md files

posva
posva requested changes Jan 27, 2021
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove all the changes to docs-gitbook? those files should be removed

@FAKER-A
Copy link
Contributor Author

FAKER-A commented Jan 27, 2021

Can you remove all the changes to docs-gitbook? those files should be removed

Ok Thanks Reply

posva
posva requested changes Jan 27, 2021
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The types were originally in flow, can you adapt them to TS by changing the ?{} into void as well?

Thanks!

posva
posva approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva changed the title docs: Add type to the code of some md files docs: add type to the code of some md files Jan 28, 2021
@posva posva merged commit 2e4508a into vuejs:dev Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FAKER-A @posva