Expose meta in Route objects #602
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose route.meta to allow reading RouteConfig.meta in transition hooks.
Reasons:
In 1.0, we used to pass Custom Fields( like
auth
in route configs, as the document suggested), but in 2.0 these custom fields aren't exposed inroute
object.I've noticed that in
RouteConfig
, there is an optional fieldmeta
, which i guess serves the functionality of the previous Custom Fields, judging from the fact that 1). It's type is any 2).there are no usage references of it in the source code.So I guess
meta
should be exposed in route objects, otherwise there is no need to define it in the first place.