Skip to content

docs(ja): Refine testing-vuex-in-components doc #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2018
Merged

docs(ja): Refine testing-vuex-in-components doc #1042

merged 2 commits into from
Nov 25, 2018

Conversation

oohira
Copy link
Contributor

@oohira oohira commented Nov 25, 2018

  • fix incorrect indentation
  • replace shallow with shallowMount
  • replace 検討 with 検証 for translation of assert
  • delete redundant translation または呼び出されていない

@eddyerburgh eddyerburgh requested a review from kazupon November 25, 2018 12:49
kazupon
kazupon approved these changes Nov 25, 2018
View reviewed changes
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

eddyerburgh
eddyerburgh approved these changes Nov 25, 2018
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@eddyerburgh eddyerburgh merged commit b8cc5e8 into vuejs:dev Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyerburgh eddyerburgh eddyerburgh approved these changes

+1 more reviewer

@kazupon kazupon kazupon approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oohira @kazupon @eddyerburgh