fix(stubs): function in props should be rendered as a deterministic string #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this for now since it seems like I'm breaking some tests in previous versions... Will debug later. |
|
Hi @briwa! Did you have the chance to have a look? It would be great to have this working. |
|
Hello! Is this PR moving forward? It's quite annoying to create workarounds for testing snapshots with functions. The proposed solution looks good to me. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #975 and #1209.
I figured that the root cause was the stubs rendering function as it is, while it should just have been a string placeholder. My idea is to override all functions in props to a placeholder, and since it's stubbed, the actual function implementation doesn't really matter (CMIIW).
Let me know if this is good enough, or if you have any feedback. Thanks.