Skip to content

Adds Context to attachTo Option Example #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2020
Merged

Conversation

CentroDL
Copy link
Contributor

@CentroDL CentroDL commented Jul 1, 2020

Previously, the documentation for attachTo provided an example where a component was being attached to a div with an id of root, but without it being defined it's kind of distracting. This update explicitly defines the element and attaches it to the document for clarity.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • [ x] Other, please describe: Documentation Change

Does this PR introduce a breaking change? (check one)

  • Yes
  • [ x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Previously, the documentation for attachTo provided an example where a component was being attached to a div with an id of `root`, but without it being defined it's kind of distracting. This update explicitly defines the element and attaches it to the document for clarity.
@lmiller1990 lmiller1990 merged commit b8da036 into vuejs:dev Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants