Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp Getting Started #1613

Merged
merged 6 commits into from
Jul 14, 2020
Merged

Revamp Getting Started #1613

merged 6 commits into from
Jul 14, 2020

Conversation

afontcu
Copy link
Member

@afontcu afontcu commented Jul 13, 2020

Revamp the Getting Started section to match docs for VTU2.

Besides that, this PR:

  • Adds reference to Vue Testing Lib.
  • Reduces the prominence of Shallow Mounting.
  • Fixes some headings and styling here and there.

@afontcu afontcu requested a review from lmiller1990 July 13, 2020 16:34
lmiller1990
lmiller1990 approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, great improvements here.

I wonder if we can share some of the guides in VTU and VTU next? This would be ideal. 🤔 At least the high level ones should be very similar (if not identical?)

docs/guides/getting-started.md Outdated
test('displays message', () => {
// mount() returns a wrapped Vue component we can interact with
const wrapper = mount(MessageComponent, {
props: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is propsData in VTU V1 🤔

We should backport props perhaps.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dang, you're right. fixed.

and yeah, maybe porting back props to match VTU 2 is a sensible idea 🤔

@lmiller1990 lmiller1990 merged commit ef6f166 into dev Jul 14, 2020
@lmiller1990 lmiller1990 deleted the update-docs branch July 14, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmiller1990 lmiller1990 lmiller1990 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@afontcu @lmiller1990