[zh-cn] synced from #de89293 to #a5ad66a #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Justineo
reviewed
Nov 11, 2017
| import sinon from 'sinon' | ||
|
|
||
| describe('点击事件', () => { | ||
| it('在 yes 按钮上点击会调用我们的方法并附带参数 "yes"', () => { |
There was a problem hiding this comment.
其它几个页面的我都翻译了，也可以保留，翻译的时候确实有点纠结
Btw，我纠结的地方还不止这一处，可以待我稍后整理一下然后集中起来再讨论
| @@ -46,15 +46,15 @@ npm install --save-dev jest-vue | |||
| "vue" | |||
| ], | |||
| "transform": { | |||
| // 用 `jest-vue` 处理 `*.vue` 文件 | |||
| ".*\\.(vue)$": "<rootDir>/node_modules/jest-vue" | |||
| // 用 `vue-jest` 处理 `*.vue` 文件 | |||
There was a problem hiding this comment.
我也发现了
@yyx990803 我留意到这部分英文文档正好是你提交的 f68e1ed 方便拿个主意吗？是否担心这会误导开发者在 package.json 里写 JS 注释导致出错？
谢谢
|
Hey guys, if a native speaker could confirm these changes I'll merge |
yyx990803
approved these changes
Nov 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: de89293...a5ad66a
The main updates is
guides/dom-events,api/wrapper/destroyandapi/wrapper-array/destroy./ping @Justineo @fnlctrl
Thanks.