Skip to content

[Doc KR] kr/* translated #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 100 commits into from
Dec 7, 2017
Merged

[Doc KR] kr/* translated #187

merged 100 commits into from
Dec 7, 2017

Conversation

ChangJoo-Park
Copy link
Contributor

Related issue : #186

@reyoucat
Copy link
Contributor

reyoucat commented Dec 6, 2017

@eddyerburgh have finished reviewing all the files.

@eddyerburgh
Copy link
Member

Awesome, great job 🙂

There are some linting errors that need to fixed before we can merge. You can run doc linting: npm run lint:docs

@ChangJoo-Park
Copy link
Contributor Author

I'll do linting :)

@ChangJoo-Park
Copy link
Contributor Author

ChangJoo-Park commented Dec 6, 2017

@eddyerburgh Lint is done. @reyoucat is best reviewer I've ever met.

@reyoucat , @marocchino 감사합니다 👍

@eddyerburgh
Copy link
Member

Great work guys, thanks for your hard work 🙏

@eddyerburgh eddyerburgh merged commit 23a97de into vuejs:dev Dec 7, 2017
@ChangJoo-Park ChangJoo-Park deleted the dev-korean branch December 10, 2017 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants