Skip to content

Update docs/en/guides/dom-events.md #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 10, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions docs/en/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,23 +26,24 @@
- [attrs](api/options.md#attrs)
- [listeners](api/options.md#listeners)
- [clone](api/options.md#clone)
- [provide](api/options.md#provide)
* [Wrapper](api/wrapper/README.md)
* [attributes](api/wrapper/attributes.md)
* [classes](api/wrapper/classes.md)
* [contains](api/wrapper/contains.md)
* [emitted](api/wrapper/emitted.md)
* [emittedByOrder](api/wrapper/emittedByOrder.md)
* [exists](api/wrapper/exists.md)
* [destroy](api/wrapper/destroy.md)
* [find](api/wrapper/find.md)
* [findAll](api/wrapper/findAll.md)
* [hasAttribute](api/wrapper/hasAttribute.md)
* [hasClass](api/wrapper/hasClass.md)
* [hasProp](api/wrapper/hasProp.md)
* [hasStyle](api/wrapper/hasStyle.md)
* [html](api/wrapper/html.md)
* [is](api/wrapper/is.md)
* [isEmpty](api/wrapper/isEmpty.md)
* [isVueInstance](api/wrapper/isVueInstance.md)
* [name](api/wrapper/name.md)
* [props](api/wrapper/props.md)
* [setComputed](api/wrapper/setComputed.md)
* [setData](api/wrapper/setData.md)
* [setMethods](api/wrapper/setMethods.md)
Expand All @@ -55,9 +56,6 @@
* [contains](api/wrapper-array/contains.md)
* [exists](api/wrapper/exists.md)
* [destroy](api/wrapper-array/destroy.md)
* [hasAttribute](api/wrapper-array/hasAttribute.md)
* [hasClass](api/wrapper-array/hasClass.md)
* [hasProp](api/wrapper-array/hasProp.md)
* [hasStyle](api/wrapper-array/hasStyle.md)
* [is](api/wrapper-array/is.md)
* [isEmpty](api/wrapper-array/isEmpty.md)
Expand Down
1 change: 1 addition & 0 deletions docs/en/SUMMARY.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
- [attrs](api/options.md#attrs)
- [listeners](api/options.md#listeners)
- [clone](api/options.md#clone)
- [provide](api/options.md#provide)
* [Wrapper](api/wrapper/README.md)
* [attributes](api/wrapper/attributes.md)
* [classes](api/wrapper/classes.md)
Expand Down
7 changes: 4 additions & 3 deletions docs/en/api/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@
- [attrs](./options.md#attrs)
- [listeners](./options.md#listeners)
- [clone](./options.md#clone)
- [provide](./options.md#provide)
* [Wrapper](./wrapper/README.md)
* [attributes](./wrapper/attributes.md)
* [classes](./wrapper/classes.md)
* [contains](./wrapper/contains.md)
* [emitted](./wrapper/emitted.md)
* [emittedByOrder](./wrapper/emittedByOrder.md)
Expand All @@ -29,6 +32,7 @@
* [isEmpty](./wrapper/isEmpty.md)
* [isVueInstance](./wrapper/isVueInstance.md)
* [name](./wrapper/name.md)
* [props](./wrapper/props.md)
* [setComputed](./wrapper/setComputed.md)
* [setData](./wrapper/setData.md)
* [setMethods](./wrapper/setMethods.md)
Expand All @@ -41,9 +45,6 @@
* [contains](./wrapper-array/contains.md)
* [exists](./wrapper/exists.md)
* [destroy](./wrapper-array/destroy.md)
* [hasAttribute](./wrapper-array/hasAttribute.md)
* [hasClass](./wrapper-array/hasClass.md)
* [hasProp](./wrapper-array/hasProp.md)
* [hasStyle](./wrapper-array/hasStyle.md)
* [is](./wrapper-array/is.md)
* [isEmpty](./wrapper-array/isEmpty.md)
Expand Down
2 changes: 1 addition & 1 deletion docs/en/api/options.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ Vue options are passed to the component when a new instance is created. , e.g. `
- [`localVue`](#localvue)
- [`attachToDocument`](#attachtodocument)
- [`attrs`](#attrs)
- [`provide`](#provide)
- [`listeners`](#listeners)
- [`clone`](#clone)
- [`provide`](#provide)

### `context`

Expand Down
18 changes: 17 additions & 1 deletion docs/en/guides/dom-events.md
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,23 @@ describe('Key event tests', () => {

A key name after the dot `keydown.up` is translated to a `keyCode`. This is supported for the following names:

* `enter`, `tab`, `delete`, `esc`, `space`, `up`, `down`, `left`, `right`
| key name | key code |
| --- | --- |
| enter | 13 |
| esc | 27 |
| tab | 9 |
| space | 32 |
| delete | 46 |
| backspace | 8 |
| insert | 45 |
| up | 38 |
| down | 40 |
| left | 37 |
| right | 39 |
| end | 35 |
| home | 36 |
| pageup | 33 |
| pagedown | 34 |

## Important

Expand Down
2 changes: 0 additions & 2 deletions src/lib/find-vue-components.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ function findAllVueComponentsFromVm (vm: Component, components: Array<Component>
}

function findAllVueComponentsFromVnode (vnode: Component, components: Array<Component> = []): Array<Component> {
debugger
if (vnode.child) {
components.push(vnode.child)
}
Expand All @@ -30,7 +29,6 @@ export function vmCtorMatchesName (vm: Component, name: string): boolean {
}

export default function findVueComponents (root: Component, componentName: string): Array<Component> {
debugger
const components = root._isVue ? findAllVueComponentsFromVm(root) : findAllVueComponentsFromVnode(root)
return components.filter((component) => {
if (!component.$vnode) {
Expand Down
6 changes: 5 additions & 1 deletion test/resources/components/component-with-events.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<button class="click" @click="clickHandler" id="button" />
<button class="left-click" @mousedown="mousedownHandler" />
<div @click="toggleActive" v-bind:class="{ toggle: true, active: isActive }" />
<input class="keydown" type="text" @keydown="keydownHandler" />
<input class="keydown" type="text" @keyup="keyupHandler" @keydown="keydownHandler" />
<input class="keydown-enter" type="text" @keydown.enter="keydownHandler" />
</div>
</template>
Expand All @@ -16,6 +16,10 @@
type: Function,
default: () => {}
},
keyupHandler: {
type: Function,
default: () => {}
},
keydownHandler: {
type: Function,
default: () => {}
Expand Down
29 changes: 29 additions & 0 deletions test/unit/specs/mount/Wrapper/trigger.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,35 @@ describe('trigger', () => {
expect(keydownHandler.calledOnce).to.equal(true)
})

it('convert a registered key name to a key code', () => {
const modifiers = {
enter: 13,
esc: 27,
tab: 9,
space: 32,
delete: 46,
backspace: 8,
insert: 45,
up: 38,
down: 40,
left: 37,
right: 39,
end: 35,
home: 36,
pageup: 33,
pagedown: 34
}
const keyupHandler = sinon.stub()
const wrapper = mount(ComponentWithEvents, {
propsData: { keyupHandler }
})
for (const keyName in modifiers) {
const keyCode = modifiers[keyName]
wrapper.find('.keydown').trigger(`keyup.${keyName}`)
expect(keyupHandler.lastCall.args[0].keyCode).to.equal(keyCode)
}
})

it('causes DOM to update after clickHandler method that changes components data is called', () => {
const wrapper = mount(ComponentWithEvents)
const toggle = wrapper.find('.toggle')
Expand Down