Skip to content

Conversation

38elements
Copy link
Contributor

@38elements 38elements commented Feb 27, 2018

This adds add docs/ja/api/renderToString.md.

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビュー 👀 コメント 💬 しました。
確認お願いします!

const renderedString = renderToString(Foo, {
slots: {
default: [Bar, FooBar],
fooBar: FooBar, // Will match <slot name="FooBar" />,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントも翻訳しておくといいと思います。

@38elements
Copy link
Contributor Author

@kazupon
レビューありがとうございます。
指摘していただいた箇所を修正しました。
よろしくお願いします。

Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😄

Note that we're splitting this into a new package right now, so the docs will have to change a bit—#447

@eddyerburgh eddyerburgh merged commit fc30c5e into vuejs:dev Feb 28, 2018
@38elements 38elements deleted the document branch March 20, 2018 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants