Skip to content

[docs][en] Replace from mapCoverage to collectCoverage in Jest sample. #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2018
Merged

[docs][en] Replace from mapCoverage to collectCoverage in Jest sample. #493

merged 3 commits into from
Mar 30, 2018

Conversation

potato4d
Copy link
Contributor

The mapCoverage option is already deprecated.
If you move this sample, an error will be displayed and it will not work.
The error is displayed as "Option 'mapCoverage' has been removed, as it no longer necessary."

Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😀

Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove collectCoverage from the config example. We already have it in the following example

@potato4d
Copy link
Contributor Author

@eddyerburgh
Which example should I delete?
collectCoverage still seems necessary.

@@ -49,7 +49,7 @@ Next, create a `jest` block in `package.json`:
// process `*.vue` files with `vue-jest`
".*\\.(vue)$": "<rootDir>/node_modules/vue-jest"
},
"mapCoverage": true
"collectCoverage": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove collectCoverage from here, since the previous example wasn't collecting coverage

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eddyerburgh Oh, OK!

@potato4d
Copy link
Contributor Author

@eddyerburgh fix it.

Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants