Skip to content

feat: render default slot in stubs #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

feat: render default slot in stubs #717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b77677
feat: render default slot in stubs
eddyerburgh Jun 14, 2018
8cbfdef
Merge branch 'dev' into render-slots-in-stubs
eddyerburgh Jun 21, 2018
3cecf84
Update stubs.spec.js
eddyerburgh Jun 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/shared/stub-components.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,9 @@ function createBlankStub (originalComponent: Component) {
return {
...getCoreProperties(originalComponent),
render (h) {
return h(name)
return h(`${originalComponent.name}-stub`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line does not need to change.

const name = `${originalComponent.name}-stub`

!originalComponent.functional && this.$slots.default
)
}
}
}
Expand Down
19 changes: 19 additions & 0 deletions test/specs/mounting-options/stubs.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,25 @@ describeWithMountingMethods('options.stub', mountingMethod => {
}
)

it('renders slot content in stubs', () => {
const TestComponent = {
template: `
<div>
<stub-with-child>
<child-component />
</stub-with-child>
</div>
`
}
const wrapper = mountingMethod(TestComponent, {
stubs: ['child-component', 'stub-with-child']
})
const HTML = mountingMethod.name === 'renderToString'
? wrapper
: wrapper.html()
expect(HTML).to.contain('<child-component-stub>')
})

it('stubs components on component if they do not already exist', () => {
const ComponentWithGlobalComponent = {
render: h => h('registered-component')
Expand Down